[PATCH] D103386: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++

Nemanja Ivanovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 31 03:25:13 PDT 2021


nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks for fixing this.



================
Comment at: clang/lib/Headers/ppc_wrappers/xmmintrin.h:31
    use vector SIMD operations. We recommend this for new applications. */
 #error "Please read comment above.  Use -DNO_WARN_X86_INTRINSICS to disable this error."
 #endif
----------------
I agree that it would be good to get rid of the extra space. :)


================
Comment at: clang/test/CodeGen/ppc-xmmintrin.c:1433
 test_prefetch() {
-  _mm_prefetch(ms, i);
+  _mm_prefetch(ms, (enum _mm_hint)i);
 }
----------------
I am not sure if this file has any tests that use the actual enumerators rather than an integer, but it seems like we should.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103386/new/

https://reviews.llvm.org/D103386



More information about the cfe-commits mailing list