[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 29 02:10:45 PDT 2021


HazardyKnusperkeks added inline comments.


================
Comment at: clang/unittests/Format/FormatTest.cpp:14884
   Alignment.AlignConsecutiveDeclarations = FormatStyle::ACS_None;
+  Alignment.PointerAlignment = FormatStyle::PAS_Right;
   verifyFormat("float const a = 5;\n"
----------------
gergap wrote:
> HazardyKnusperkeks wrote:
> > Why change this?
> It is already set to PAS_Right by default. But when reading the code you don't know this. I needed to debug this to find this out.
> The following verifyFormat tests depend on PAS_Right style.
Then make it an EXPECT_EQ.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103245/new/

https://reviews.llvm.org/D103245



More information about the cfe-commits mailing list