[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo
    Fangrui Song via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Thu May 27 19:37:07 PDT 2021
    
    
  
MaskRay added subscribers: compnerd, dblaikie.
MaskRay added a comment.
Because of `new MCObjectFileInfo`, we cannot use a forward declaration (incomplete class) to replace `#include "llvm/MC/MCObjectFileInfo.h"` in `TargetRegistry.h`.
I thought about moving `TargetRegistry.{h,cpp}` from Support to Target. However, it doesn't work because Bitcode/Object call `TargetRegistry::lookupTarget` and Bitcode/Object are lower than Target.
@compnerd @dblaikie @mehdi_amini Do you have suggestions on fixing the layering?
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101921/new/
https://reviews.llvm.org/D101921
    
    
More information about the cfe-commits
mailing list