[PATCH] D95228: Add swift_async_context parameter attribute mapping to IR equivalent
Tim Northover via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 28 04:31:42 PDT 2021
t.p.northover closed this revision.
t.p.northover marked an inline comment as done.
t.p.northover added a comment.
Thanks, committed as e94fada045fe <https://reviews.llvm.org/rGe94fada045fe88787a414e3307412c1cc3a1b259> with the extra tests.
================
Comment at: clang/include/clang/Basic/AttrDocs.td:4404
+
+A context parameter must have pointer or reference type.
+ }];
----------------
aaron.ballman wrote:
> Should we specify whether pointer to members or ObjC object pointers are fine (given that those are both somewhat "odd" pointer types)? Function pointers?
>
> (We may want to clarify this in the other docs in a follow-up if we think this is unclear.)
I don't think either of those are banned, but it's kind of a "play silly games win silly prizes" situation.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95228/new/
https://reviews.llvm.org/D95228
More information about the cfe-commits
mailing list