[PATCH] D102633: [clang-scan-deps] Improvements to thread usage

Alexandre Ganea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 27 20:31:54 PDT 2021


aganea added a comment.

@dexonsmith Yes, using the Clang Tooling API seems like a good option, however some logic could/would be needed from `clang/tools/clang-scan-deps/ClangScanDeps.cpp`. Using clang-scan-deps as-a-DLL seemed like the best option on the short term, since we're using its `main()` //almost// verbatim with only a few minor changes. We still need to solve a contention issue related to the Windows implementation of `sys::fs::status()`, but then once everything is sorted out we'll re-consider the usage of the DLL.

In the meanwhile, do you have any opinion on this patch and/or on https://reviews.llvm.org/D102633#2773578 ? Do you think there's value for users?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102633/new/

https://reviews.llvm.org/D102633



More information about the cfe-commits mailing list