[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations
Aaron Puchert via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 27 16:50:59 PDT 2021
aaronpuchert added a comment.
In D101566#2785271 <https://reviews.llvm.org/D101566#2785271>, @dblaikie wrote:
> Right - to remove -Wweak-template-vtable in its entirety. The original implementation explicitly didn't warn on implicit instantiations and I think the fact that it warned on explicit instantiations is more bug than feature - and we should treat it that way.
What about `-Wweak-vtables`, what's the reasoning for keeping that?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101566/new/
https://reviews.llvm.org/D101566
More information about the cfe-commits
mailing list