[PATCH] D102970: [clang] [MinGW] Don't mark emutls variables as DSO local

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 27 11:32:42 PDT 2021


mstorsjo added a comment.

@rnk Does this seem ok to you too?



================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:992
+    // (and this actually happens in the public interface of libstdc++), so
+    // such variables can't be marked as DSO local.
     if (GV->isDeclarationForLinker() && isa<llvm::GlobalVariable>(GV) &&
----------------
I guess that it’d be good to point out the reverse too, that native tls variables on windows can’t be dllimported.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102970/new/

https://reviews.llvm.org/D102970



More information about the cfe-commits mailing list