[PATCH] D103231: [clang][AST] Set correct DeclContext in ASTImporter lookup table for ParmVarDecl.

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 27 06:59:50 PDT 2021


martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: rnkovacs.

Thanks, looks good to me, with a nit in the tests.



================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:6199
+  EXPECT_TRUE(ImportedF);
+  EXPECT_FALSE(
+      SharedStatePtr->getLookupTable()
----------------
Instead of `.empty()`, perhaps we should examine if the found entry is indeed the imported ParmVarDecl.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103231/new/

https://reviews.llvm.org/D103231



More information about the cfe-commits mailing list