[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

[Pengfei Wang via Phabricator via cfe-commits]

pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.

LGTM. But let's wait one or more days to see if others have more comments.



================
Comment at: clang/lib/Sema/SemaChecking.cpp:4762
+
+  for (ParmVarDecl *Param : FDecl->parameters()) {
+    CheckTargetTypeSupport(Context.getTargetInfo(), Param->getType(),
----------------
Nit: We can save the curly bracket for it.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:14202
+    if (CheckTargetTypeSupport(Context.getTargetInfo(), Param->getType(),
+                               Param->getLocation(), /*IsReturnType=*/false)) {
+      HasInvalidParm = true;
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98895/new/

https://reviews.llvm.org/D98895