[PATCH] D103179: [clangd] Handle queries without an originating file in ProjectAwareIndex

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 26 09:18:56 PDT 2021


kadircet added a comment.

Note that I don't feel strongly about making use of `Context` to figure out config::Params vs moving the `Params` into the `Config`. But I'd rather not only store `Path` in the `Config` since we might end up needing other environment variables in future.

I didn't go with the Context option as it is hard to find a place to fetch it. Maybe we can just forward declare it in Config.h and have a `Config::Params` similar to `Config::Current`. (but this would decouple the Config and  Params that generated it :/)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103179/new/

https://reviews.llvm.org/D103179



More information about the cfe-commits mailing list