[PATCH] D102779: [clang-tidy] cppcoreguidelines-explicit-constructor-and-conversion: new alias

Marco Gartmann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 26 08:27:07 PDT 2021


mgartmann added a comment.

@aaron.ballman Thanks a lot for your valuable feedback! I incorporated it accordingly.

Is there anything else that should be improved?



================
Comment at: clang-tools-extra/clang-tidy/google/ExplicitConstructorCheck.cpp:102
   if (const auto *Conversion =
-      Result.Nodes.getNodeAs<CXXConversionDecl>("conversion")) {
+          Result.Nodes.getNodeAs<CXXConversionDecl>("conversion")) {
     if (Conversion->isOutOfLine())
----------------
aaron.ballman wrote:
> Unintended formatting change?
This formatting change was done by `clang-format` when `git clang-format HEAD~1` was run. Therefore, I assumed that it is now correctly formatted. 

Am I wrong?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102779/new/

https://reviews.llvm.org/D102779



More information about the cfe-commits mailing list