[PATCH] D103157: Disable misc-no-recursion checking in Clang

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman created this revision.
aaron.ballman added reviewers: alexfh, njames93, rsmith.
aaron.ballman requested review of this revision.
Herald added a subscriber: aheejin.
Herald added a project: clang.

We currently enable `misc-no-recursion`, but Clang uses recursion intentionally in a fair number of places (like `RecursiveASTVisitor`). Disabling this check reduces a noise in reviews that add new AST nodes, like https://reviews.llvm.org/D103112#2780747 which has five CI warnings that the author can do nothing about.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D103157

Files:
  clang/.clang-tidy


Index: clang/.clang-tidy
===================================================================
--- clang/.clang-tidy
+++ clang/.clang-tidy
@@ -1,4 +1,4 @@
-Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,-readability-identifier-naming'
+Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,-readability-identifier-naming,-misc-no-recursion'
 # Note that the readability-identifier-naming check is disabled, there are too
 # many violations in the codebase and they create too much noise in clang-tidy
 # results.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103157.347926.patch
Type: text/x-patch
Size: 640 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210526/40c9a725/attachment.bin>