[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 25 23:51:30 PDT 2021


rjmccall added a comment.

Do you want to generate these even at -O0?



================
Comment at: llvm/include/llvm/IR/MatrixBuilder.h:242
+    auto *Cmp = B.CreateICmpULT(Idx, NumElts);
+    if (!isa<llvm::ConstantInt>(Cmp)) {
+      Function *TheFn =
----------------
xbolva00 wrote:
> Prefer early exit?
Should this do something special if the index is statically out of bounds?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102478/new/

https://reviews.llvm.org/D102478



More information about the cfe-commits mailing list