[PATCH] D103131: support debug info for alias variable

[Umesh Kalappa via Phabricator via cfe-commits]

umesh.kalappa0 added inline comments.


================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4948
 
+void CGDebugInfo::EmitGlobalAlias(llvm::GlobalAlias *Var, const VarDecl *D) {
+  if (!CGM.getCodeGenOpts().hasReducedDebugInfo())
----------------
Var is never used in the EmitGlobalAlias ,we don't need the same.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4929
+    if (CGDebugInfo *DI = getModuleDebugInfo())
+      if (getCodeGenOpts().hasReducedDebugInfo())
+        DI->EmitGlobalAlias(GA, VD);
----------------
this should be other way right  i.e if(!getCodeGenOpts().hasReducedDebugInfo())


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103131/new/

https://reviews.llvm.org/D103131