[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

Tue May 25 15:42:40 PDT 2021

hctim marked 2 inline comments as done.
hctim added inline comments.

================
Comment at: compiler-rt/test/scudo/standalone/CMakeLists.txt:13-14
+  string(TOLOWER "-${arch}" SCUDO_STANDALONE_TEST_CONFIG_SUFFIX)
+  get_test_cc_for_arch(${arch} SCUDO_STANDALONE_TEST_TARGET_CC
+                       SCUDO_STANDALONE_TEST_TARGET_CFLAGS)
+  string(TOUPPER ${arch} ARCH_UPPER_CASE)
----------------
vitalybuka wrote:
> This places breaks ppc build and I don't understand why we need it
Yeah, `get_test_cc_for_arch` looks wrong to me. But we do still need one of its children, `get_target_flags_for_arch`, otherwise host cross-compile (from amd64 -> i386) fails.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102543/new/

https://reviews.llvm.org/D102543