[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

[Haowei Wu via Phabricator via cfe-commits]

haowei added a comment.

This CL breaks our mac builders as well. Could you either fix the test or revert the change please?

Error message:

  ******************** TEST 'Clang :: CodeGenCXX/const-dynamic-init.cpp' FAILED ********************
  Script:
  --
  : 'RUN: at line 1';   /opt/staging/llvm_build/bin/clang -cc1 -internal-isystem /opt/staging/llvm_build/lib/clang/13.0.0/include -nostdsysteminc -triple x86_64-apple-darwin19.6.0 -emit-llvm -o - /opt/llvm-project/clang/test/CodeGenCXX/const-dynamic-init.cpp | /opt/staging/llvm_build/bin/FileCheck /opt/llvm-project/clang/test/CodeGenCXX/const-dynamic-init.cpp
  --
  Exit Code: 2
  
  Command Output (stderr):
  --
  /opt/llvm-project/clang/test/CodeGenCXX/const-dynamic-init.cpp:3:24: error: argument to 'section' attribute is not valid for this target: mach-o section specifier requires a segment and section separated by a comma
  __attribute__((section("A")))
                         ^
  /opt/llvm-project/clang/test/CodeGenCXX/const-dynamic-init.cpp:9:24: error: argument to 'section' attribute is not valid for this target: mach-o section specifier requires a segment and section separated by a comma
  __attribute__((section("B")))
                         ^
  /opt/llvm-project/clang/test/CodeGenCXX/const-dynamic-init.cpp:15:24: error: argument to 'section' attribute is not valid for this target: mach-o section specifier requires a segment and section separated by a comma
  __attribute__((section("C")))
                         ^
  /opt/llvm-project/clang/test/CodeGenCXX/const-dynamic-init.cpp:19:24: error: argument to 'section' attribute is not valid for this target: mach-o section specifier requires a segment and section separated by a comma
  __attribute__((section("D")))
                         ^
  /opt/llvm-project/clang/test/CodeGenCXX/const-dynamic-init.cpp:23:24: error: argument to 'section' attribute is not valid for this target: mach-o section specifier requires a segment and section separated by a comma
  __attribute__((section("E")))
                         ^
  5 errors generated.
  FileCheck error: '<stdin>' is empty.
  FileCheck command line:  /opt/staging/llvm_build/bin/FileCheck /opt/llvm-project/clang/test/CodeGenCXX/const-dynamic-init.cpp
  
  --
  
  ********************


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102693/new/

https://reviews.llvm.org/D102693