[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 24 12:09:42 PDT 2021


aaron.ballman added a comment.

In D49864#2777774 <https://reviews.llvm.org/D49864#2777774>, @janosimas wrote:

> I manage to upload it, copy-pasting the content to the text box. I have no idea why it is not working with the upload.
>
> Updates from the last change
>
> - Modified the tests to match the input
> - Addend file context

Can confirm that the new diff looks to have not been munged somehow. Sorry that you had the weird Phab issues, hopefully they're transitory and won't crop up again on the review.

The changes seem reasonable to me, but you should wait for @alexfh to sign off on the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49864/new/

https://reviews.llvm.org/D49864



More information about the cfe-commits mailing list