[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM aside from some minor nits.



================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3961
+def warn_deprecated_ignored_on_using : Warning<
+  "%0 currently has no effect on using-declarations">,
+  InGroup<IgnoredAttributes>;
----------------



================
Comment at: clang/lib/Parse/ParseDeclCXX.cpp:501
   return ParseUsingDeclaration(Context, TemplateInfo, UsingLoc, DeclEnd,
-                               AS_none);
+                               attrs, AS_none);
 }
----------------
Might as well clang-format this (same for the other clang-format issues where you've changed the code).


================
Comment at: clang/lib/Parse/ParseDeclCXX.cpp:693
+            Tok.getLocation(),
+            CharSourceRange::getTokenRange(MisplacedAttrs.Range))
+        << FixItHint::CreateRemoval(MisplacedAttrs.Range);
----------------
You can ignore this clang-format message though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91630/new/

https://reviews.llvm.org/D91630