[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 24 07:17:32 PDT 2021


aaron.ballman added a comment.

In D49864#2776570 <https://reviews.llvm.org/D49864#2776570>, @janosimas wrote:

> Hi, sorry for taking so long for such a small change.
> I did the changes and generated a diff with the requested context.
> It's a huge file with a lot more diff than my changes, is that right?

That sounds incorrect. The generated diff should be basically the same size as what's already in the review.

> When I try to upload it, I'm getting `Unhandled Exception ("Exception")`, no other error message.
> Any suggestions there?

That sounds like a Phabricator issue, but perhaps it has to do with an unexpectedly large patch file. I'd recommend first getting the patch file to the point it looks reasonable, and then if the Phab issues persist, we can investigate them at that point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49864/new/

https://reviews.llvm.org/D49864



More information about the cfe-commits mailing list