[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

[Ella Ma via Phabricator via cfe-commits]

OikawaKirie updated this revision to Diff 347327.
OikawaKirie added a comment.
Herald added a subscriber: manas.

In D101763#2768549 <https://reviews.llvm.org/D101763#2768549>, @martong wrote:

> First of all, thank you for the patch!
> We had a meeting with my colleges (@steakhal, @gamesh411) and we agreed in the following. This is indeed an issue and the fix is okay. About the test, we'd like to ask if you could create a small test lib with its own 'open' function that would simply call the system's open and would print 'open'. And then with LD_PREOLOAD you could use that lib in the lit test. (If that approach is not working for some reason then we may just mark the test with XFAIL.)

Updated as suggested based on a previous submit https://reviews.llvm.org/D101763?id=343346. An empty invocation list is used to trigger a parsing failure, and name `invocations.yaml` is used as the file name for logging and checking.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101763/new/

https://reviews.llvm.org/D101763

Files:
  clang/include/clang/CrossTU/CrossTranslationUnit.h
  clang/lib/CrossTU/CrossTranslationUnit.cpp
  clang/test/Analysis/ctu-on-demand-parsing-multiple-invocation-list-parsing.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101763.347327.patch
Type: text/x-patch
Size: 5067 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210524/632ef8a5/attachment-0001.bin>