[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 21 18:20:54 PDT 2021


dexonsmith added a subscriber: jansvoboda11.
dexonsmith added a comment.

In D102943#2775115 <https://reviews.llvm.org/D102943#2775115>, @pcc wrote:

> Isn't the bug here that module hashing is using `hash_code`? So shouldn't the correct fix be to use a specific hashing algorithm for module hashes?

Yeah, I tend to agree. I thought modules already used MD5, but maybe just for the AST signature.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102943/new/

https://reviews.llvm.org/D102943



More information about the cfe-commits mailing list