[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked 2 inline comments as done.
yaxunl added inline comments.


================
Comment at: clang/lib/Headers/__clang_hip_cmath.h:20
 #include <limits>
 #include <type_traits>
 #include <utility>
----------------
ashi1 wrote:
> we may not need to `#include` limits and/or type_traits if we replaced them with `__hip::is_integral` and `__hip::is_arithmetic`.
right. but we may need to move them to HIP headers first if HIP headers need them.


================
Comment at: clang/lib/Headers/__clang_hip_cmath.h:587
 #endif
-#endif
+#endif // !defined(__HIPCC_RTC__)
 
----------------
ashi1 wrote:
> I don't think this `#endif` is for `!defined(__HIPCC_RTC__)`. It should be for `_LIBCPP_BEGIN_NAMESPACE_STD`.
You are right. fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100794/new/

https://reviews.llvm.org/D100794