[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

[Teresa Johnson via Phabricator via cfe-commits]

tejohnson added a comment.

In D102742#2774185 <https://reviews.llvm.org/D102742#2774185>, @nickdesaulniers wrote:

> - upgrade module merge strategy to Error

Probably want a test using llvm-link or llvm-lto to check this behavior (that alike flags are getting propagated as expected and that conflicting ones error)



================
Comment at: clang/include/clang/Driver/Options.td:3429
   HelpText<"Use the given reg for addressing the stack-protector guard">,
-  MarshallingInfoString<CodeGenOpts<"StackProtectorGuardReg">, [{"none"}]>;
+  MarshallingInfoString<CodeGenOpts<"StackProtectorGuardReg">>;
 def mfentry : Flag<["-"], "mfentry">, HelpText<"Insert calls to fentry at function entry (x86/SystemZ only)">,
----------------
What's the effect of or reason for this change?


================
Comment at: clang/test/CodeGen/stack-protector-guard.c:4
+// RUN:            -mstack-protector-guard-offset=1024 \
+// RUN:            -emit-llvm %s -o - | FileCheck %s
+void foo(int*);
----------------
Perhaps add a check that the module flags not added without these options


================
Comment at: llvm/include/llvm/IR/Module.h:898
 
+  StringRef getStackProtectorGuard() const;
+  void setStackProtectorGuard(StringRef Kind);
----------------
add a doxygen comment like the ones for the other interfaces here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102742/new/

https://reviews.llvm.org/D102742