[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 21 10:34:39 PDT 2021


MyDeveloperDay added a comment.

This is a valiant effort, and I definitely don't want to discourage..especially as you shown a good understand of clang-format. Its been a long asked for feature.. but we should really ensure this covers the bulk of the complaints if possible..

For me I use this.. a search for `clang-format off` in github projects

https://github.com/search?q=clang-format+off

  Status AbsGrad(const AttrSlice& attrs, FunctionDef* g) {
    // clang-format off
    return GradForUnaryCwise(g, {
        {{"sign"}, "Sign", {"x"}, {}, {"dy"}},
        {{"dx"}, "Mul", {"dy", "sign"}},
    });
    // clang-format on
  }

https://github.com/lulzsec2012/tensorflow/blob/d68d869e397515655e9f41570f4db463df770563/tensorflow/core/ops/math_grad.cc

it would be my ideal if we could irradiate the need for these, as they heavily dominate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101868/new/

https://reviews.llvm.org/D101868



More information about the cfe-commits mailing list