[PATCH] D102863: [analyzer] RetainCountChecker: Disable tracking for references to OSMetaClass.

[Georgeta Igna via Phabricator via cfe-commits]

georgi_igna updated this revision to Diff 347070.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102863/new/

https://reviews.llvm.org/D102863

Files:
  clang/lib/Analysis/RetainSummaryManager.cpp
  clang/test/Analysis/os_object_base.h
  clang/test/Analysis/osobject-retain-release.cpp


Index: clang/test/Analysis/osobject-retain-release.cpp
===================================================================
--- clang/test/Analysis/osobject-retain-release.cpp
+++ clang/test/Analysis/osobject-retain-release.cpp
@@ -721,6 +721,16 @@
    obj->release();
  }
  
++void test_osmetaclass_release(){
++  const char *name = "no_name";
++  const OSMetaClass *meta = OSMetaClass::copyMetaClassWithName(name);
++  if (!meta) {
++    return;
++  } else {
++    meta->releaseMetaClass();
++  }
++}
++
  class SampleClass {
  public:
    OSObjectPtr field;
Index: clang/test/Analysis/os_object_base.h
===================================================================
--- clang/test/Analysis/os_object_base.h
+++ clang/test/Analysis/os_object_base.h
@@ -68,6 +68,8 @@
  struct OSMetaClass : public OSMetaClassBase {
    virtual OSObject * alloc() const;
    static OSObject * allocClassWithName(const char * name);
++  static const OSMetaClass * copyMetaClassWithName(const char * name);
++  void releaseMetaClass() const;
    virtual ~OSMetaClass(){}
  };
  
Index: clang/lib/Analysis/RetainSummaryManager.cpp
===================================================================
--- clang/lib/Analysis/RetainSummaryManager.cpp
+++ clang/lib/Analysis/RetainSummaryManager.cpp
@@ -146,8 +146,15 @@
    return !(match(SubclassM, *D, D->getASTContext()).empty());
  }
  
++static bool isExactClass(const Decl *D, StringRef ClassName) {
++  using namespace ast_matchers;
++  DeclarationMatcher sameClassM =
++      cxxRecordDecl(hasName(std::string(ClassName)));
++  return !(match(sameClassM, *D, D->getASTContext()).empty());
++}
++
  static bool isOSObjectSubclass(const Decl *D) {
--  return D && isSubclass(D, "OSMetaClassBase");
++  return D && isSubclass(D, "OSMetaClassBase") && !isExactClass(D, "OSMetaClass");
  }
  
  static bool isOSObjectDynamicCast(StringRef S) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102863.347070.patch
Type: text/x-patch
Size: 1877 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210521/c4f109cd/attachment.bin>