[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

Fri May 21 09:08:53 PDT 2021

hubert.reinterpretcast added inline comments.

================
Comment at: clang/test/CodeGen/pre-ra-sched.c:1-2
+// RUN: %clang %s -mllvm -pre-RA-sched=fast -c -o - | FileCheck %s
+// RUN: %clang %s -mllvm -pre-RA-sched=linearize -c -o - | FileCheck %s
+
----------------
TaoPan wrote:
> hubert.reinterpretcast wrote:
> > hubert.reinterpretcast wrote:
> > > The test as was committed is bogus. It checks the output binary(!) stream for an error message when stderr was not even redirected. Please fix.
> > Fix committed: https://github.com/llvm/llvm-project/commit/603818b97c795114f66a6fc13e8a5f0e54b49a13
> Thanks for your review comment and fixing!
> I tried to check stderr as you guided and meet empty stdin problem, thanks for your quick fixing and I got FileCheck option --allow-empty can resolve this kind of problem. 
No problem. Thanks for looking into it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101601/new/

https://reviews.llvm.org/D101601