[PATCH] D102730: [clang-format] Support custom If macros

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 20 02:31:44 PDT 2021


HazardyKnusperkeks added a comment.

Looks good, but please add a test with the `else IF` and just `else` case.

Also for me it would be ok to add your `KJ_IF_MAYBE` to the default configuration. But I have no experience on that.



================
Comment at: clang/include/clang/Format/Format.h:2098
+  ///
+  /// For example: KJ_IF_MAYBE.
+  std::vector<std::string> IfMacros;
----------------
vlovich wrote:
> Should I put a hyperlink to https://github.com/capnproto/capnproto/blob/master/kjdoc/tour.md#maybes?
Maybe. *scnr*


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102730/new/

https://reviews.llvm.org/D102730



More information about the cfe-commits mailing list