[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints
Min-Yih Hsu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 19 23:22:03 PDT 2021
myhsu added a comment.
In D102585#2769887 <https://reviews.llvm.org/D102585#2769887>, @nickdesaulniers wrote:
> Looking good @myhsu . Also, I got your LLVM book recently! You'll need to sign it for me at the next llvm conf in person.
Thank you :-) Hope you will like it.
I'll start to practice my autograph too.
================
Comment at: clang/test/Sema/inline-asm-validate-m68k.c:51
+ asm volatile ("" :: "C0"(IncorrectVal)); // expected-error{{value '1' out of range for constraint 'C0'}}
+}
----------------
nickdesaulniers wrote:
> do we need tests for lowercase `a`, `r`, or `d`?
Actually I think `r` is already a built-in constraint letter for register. I'm adding test cases for `a` and `d` though.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102585/new/
https://reviews.llvm.org/D102585
More information about the cfe-commits
mailing list