[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

[Derek Schuff via Phabricator via cfe-commits]

dschuff added a comment.

BTW Is there a way to disable this warning?
Since IIUC this could cause code that was not warning (because it used -fno-exceptions or used emscripten's default of -fignore-exceptions) to now start warning, sometimes that makes users who use -Werror unhappy.



================
Comment at: clang/lib/CodeGen/CGException.cpp:495
+        CGM.getLangOpts().getExceptionHandling() ==
+            LangOptions::ExceptionHandlingKind::None &&
+        EST == EST_Dynamic)
----------------
Does emscripten's default of `-fignore-exceptions` also end up as haveing `ExceptionHandlingKind::None` even though exceptions aren't disabled?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102791/new/

https://reviews.llvm.org/D102791