[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 19 14:15:29 PDT 2021


mstorsjo created this revision.
mstorsjo added reviewers: MaskRay, nickdesaulniers, raj.khem.
Herald added a subscriber: kristof.beyls.
mstorsjo requested review of this revision.
Herald added a project: clang.

If multiple instances of the -arm-implicit-it option is passed to
the backend, it errors out.

Also fix cases where there are multiple -Wa,-mimplicit-it; the existing
tests indicate that the last one specified takes effect, while in
practice it passed double options, which didn't work as intended.

This goes on top of a reverted 2919222d8017f2425a85765b95e4b7c6f8e70ca4 <https://reviews.llvm.org/rG2919222d8017f2425a85765b95e4b7c6f8e70ca4>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102812

Files:
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/test/Driver/arm-target-as-mimplicit-it.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102812.346567.patch
Type: text/x-patch
Size: 7876 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210519/f608664a/attachment-0001.bin>


More information about the cfe-commits mailing list