[PATCH] D102696: [Analyzer] Find constraints that are directly attached to a BinOp

[Artem Dergachev via Phabricator via cfe-commits]

NoQ added a comment.

In D102696#2767894 <https://reviews.llvm.org/D102696#2767894>, @martong wrote:

>> In this case the equations are $y == 0 and $x + 0 == 0 which is much easier to solve.
>
> Yes, you are right.
>
>> This happens for the same reason that your patch is needed in the first place: we're eagerly substituting a constant.
>
> Absolutely, that's the point. On the other hand, it is very important to emphasize that we cannot solve this problem with a stronger solver, see my example with 3 variables and two equations above.

Well, in that other example, we should be asking about `$x + $y + 0 == 0` at some point. And then the solver should be able to deduce it from `$x + $y + $z == 0` and `$z == 0`. If we're not asking this question, that's obviously the first problem to get out of our way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102696/new/

https://reviews.llvm.org/D102696