[PATCH] D102568: [Driver] Delete -mimplicit-it=

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 19 12:38:42 PDT 2021


MaskRay added a comment.

In D102568#2769401 <https://reviews.llvm.org/D102568#2769401>, @dblaikie wrote:

> Ah, thanks for the history. Yeah, still not sure those bugs are on equal footing - if the patch had been in for a few months before musl was fixed (If they're interested in building from LLVM head - wonder why it took so long & if they aren't, then it doesn't seem like we need to rush to fix this/keep the fix in tree if backing it out and considering how to support both new-ish (self-imposed due to the -mimplicit-it= change) and existing (mingw arm) use cases can be handled gracefully and have it in the next LLVM release or the like).

The original driver option was added in 2016-07. Some projects may accrue some -mimplicit-it usage singe then.

The option -Wa,-mimplicit-it was added in 2021-02. @raj.khem noticed the issue in 2021-05. Perhaps that's not too long ? :)

> But sounds like there's some possible both-use-cases-work path forward, which is good to see.

Yes. Seems that @mstorsjo has started working on making all the use cases work.
With this, I am certainly happy that we can retain the options for a couple of releases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102568/new/

https://reviews.llvm.org/D102568



More information about the cfe-commits mailing list