[PATCH] D102568: [Driver] Delete -mimplicit-it=

Wed May 19 12:13:42 PDT 2021

MaskRay added a comment.

In D102568#2769340 <https://reviews.llvm.org/D102568#2769340>, @mstorsjo wrote:

> In the meantime, wouldn't it be possible to detect the presence of the other one and check if they match or not, to avoid passing duplicate options to the backend? I can give that a try.

Should be possible! Thanks for offering the help. I think it is too much to test contradicting values like `// NEVER_ALWAYS: "-mllvm" "-arm-implicit-it=never" "-mllvm" "-arm-implicit-it=always"`.
We can just assume having different values is undefined behavior. (No project should specify different values.)

>> I think "waiting for a few releases" is too much and doesn't improve things (they will notice issues until you remove the option). I can accept "waiting for one major release".

I said this because this would break musl arm build.

> Ok, that's at least some sort of middle ground. Would fixing the duplicate option issue (as long as they have matching values) open up for keeping both a little bit longer?

If you can make -mimplicit-it= -Wa,-mimplicit-it= work, keeping the driver option bit longer LG.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102568/new/

https://reviews.llvm.org/D102568