[PATCH] D102568: [Driver] Delete -mimplicit-it=

Wed May 19 10:23:57 PDT 2021

nickdesaulniers added a comment.

In D102568#2768224 <https://reviews.llvm.org/D102568#2768224>, @mstorsjo wrote:

> I would request that this commit should be reverted.

Sure, @MaskRay would you mind reverting?

> But this change did break my build in these places:
> https://code.videolan.org/videolan/x264/-/blob/b684ebe04a6f80f8207a57940a1fa00e25274f81/configure#L855
> https://chromium.googlesource.com/webm/libvpx/+/66c1ff6850fd53bcf5c17247569bea1d700d6247/build/make/configure.sh#1012
> https://github.com/cisco/openh264/blob/089d6c6d83ab6e5d451ef18808bb6c46faf553a2/build/platform-mingw_nt.mk#L23

Thanks for the links; @MaskRay I think you should file some issues in those projects to help them move to the assembler option before we try to remove it again.

>> Should be an easy fix either way (replace `-mimplicit-it=always` with `-Wa,-wmimplicit-it=always`).
>
> No, it's not an easy fix as no existing releases of Clang support it.

Well, these projects linked above will need to implement either feature detection for the command line flag options before hard coding them, or compiler version checks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102568/new/

https://reviews.llvm.org/D102568