[PATCH] D102715: [AIX] Fix LIT failure on native aix

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 19 09:54:19 PDT 2021


aaron.ballman added inline comments.


================
Comment at: clang/test/Sema/struct-packed-align.c:170
+#elif defined(_AIX)
+// On AIX, [bool, char, short] bitfields have the same alignment as unsigned
+// int.
----------------
We're not really testing the behavior of `bool` or `short` anywhere and it'd be nice to verify that. Perhaps instead of modifying an existing test to add more fields, it'd make sense to make a new test structure?

While thinking of other potentially smaller-than-int types, I wondered whether `wchar_t` has special behavior here as well (I have no idea how that type is defined for AIX, so it's entirely possible it's size and alignment already match `int`).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102715/new/

https://reviews.llvm.org/D102715



More information about the cfe-commits mailing list