[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

Wed May 19 08:31:48 PDT 2021

pooja2299 added inline comments.

================
Comment at: clang/include/clang/Basic/AttrDocs.td:2244-2247
+and is an optimization hint. It is mandatory to use this attribute in some 
+situations. Because when the attribute is absent, the compiler assumes the 
+default maximum workgroup size of 256 but nowadays the workgroup size can legally go 
+to 1024. 
----------------
arsenm wrote:
> aaron.ballman wrote:
> > 
> You're updating this with outdated information. In general functions should be conservatively correct by default with no attribute specified. This was broken at one point in the past. The default assumed workgroup size is now 1024, but for opencl clang will always default to a max of 256
Ohh. Thanks for your feedback. Will update it 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102134/new/

https://reviews.llvm.org/D102134