[PATCH] D102062: [analyzer][ctu] Append ctu-dir to ctu-invocation-list for non-absolute paths

Ella Ma via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 19 07:09:46 PDT 2021


OikawaKirie abandoned this revision.
OikawaKirie added a comment.

In D102062#2768569 <https://reviews.llvm.org/D102062#2768569>, @martong wrote:

> First of all, thank you for the patch!
> We had a meeting with my colleges (@steakhal, @gamesh411) and we agreed in the following.
>
> We'd like to keep the current behavior because this way the behavior is similar that we got used to with any other command line tools.

Ok, if you all agree with using `ctu-invocation-list` with a path related to CWD rather than `ctu-dir`, I will drop this revision here.
Although, I still believe that it would be better to make the behavior similar to the ctu index file, which is related to the `ctu-dir` (see the comments in the code).

Thanks for your suggestions on this revision.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102062/new/

https://reviews.llvm.org/D102062



More information about the cfe-commits mailing list