[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

Min-Yih Hsu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 18 22:17:28 PDT 2021


myhsu added inline comments.


================
Comment at: clang/lib/Basic/Targets/M68k.cpp:145
   case 'd': // data register
-  case 'f': // floating point register
     info.setAllowsRegister();
----------------
nickdesaulniers wrote:
> did you mean to drop support for `'f'`?
To drop it for now. I believe this constraint was added by mistake since we barely has any support for floating point in the backend. I think it's a good idea to remove this constraint from the frontend so that it will not be misused until floating point implementation got matured.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102585/new/

https://reviews.llvm.org/D102585



More information about the cfe-commits mailing list