[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

Vitaly Buka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 18 21:04:51 PDT 2021


vitalybuka added inline comments.


================
Comment at: compiler-rt/test/scudo/standalone/CMakeLists.txt:13-14
+  string(TOLOWER "-${arch}" SCUDO_STANDALONE_TEST_CONFIG_SUFFIX)
+  get_test_cc_for_arch(${arch} SCUDO_STANDALONE_TEST_TARGET_CC
+                       SCUDO_STANDALONE_TEST_TARGET_CFLAGS)
+  string(TOUPPER ${arch} ARCH_UPPER_CASE)
----------------
This places breaks ppc build and I don't understand why we need it


================
Comment at: compiler-rt/test/scudo/standalone/lit.site.cfg.py.in:5
+config.target_arch = "@SCUDO_STANDALONE_TEST_TARGET_ARCH@"
+config.target_cflags = "@SCUDO_STANDALONE_TEST_TARGET_CFLAGS@"
+
----------------
see above


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102543/new/

https://reviews.llvm.org/D102543



More information about the cfe-commits mailing list