[PATCH] D102736: Fix tmp files being left on Windows builds.

[Alexandre Ganea via Phabricator via cfe-commits]

aganea added a comment.

In D102736#2767516 <https://reviews.llvm.org/D102736#2767516>, @amccarth wrote:

> I seem to recall some thrashing on this topic a few months ago.  If I'm remembering correctly, setting the disposition to delete temporary files on Windows was causing problems with Rust builds because you can't always set the delete disposition (e.g., for a file on a network drive).  I think it got pulled out, and then put back in in a limited way.

It landed in rG64ab2b6825c5aeae6e4afa7ef0829b89a6828102 <https://reviews.llvm.org/rG64ab2b6825c5aeae6e4afa7ef0829b89a6828102> - it fixed the initial Rust issue. I can add a Windows 7 bot if you think it's worth it. But I'm happy to occasionally maintain the Win7 port for as long as it's needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102736/new/

https://reviews.llvm.org/D102736