[PATCH] D102728: [clang][Sema] removes -Wfree-nonheap-object reference param false positive

Christopher Di Bella via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 18 15:03:03 PDT 2021


cjdb created this revision.
cjdb added reviewers: gbiv, manojgupta, aaron.ballman.
Herald added a reviewer: george.burgess.iv.
Herald added subscribers: dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini.
Herald added a reviewer: rriddle.
cjdb requested review of this revision.
Herald added subscribers: cfe-commits, stephenneuendorffer, nicolasvasilache.
Herald added projects: clang, MLIR.

Taking the address of a reference parameter might be valid, and without
CFA, false positives are going to be more trouble than they're worth.

This reverts commit 499571ea835daf786626a0db1e12f890b6cd8f8d <https://reviews.llvm.org/rG499571ea835daf786626a0db1e12f890b6cd8f8d>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102728

Files:
  clang/lib/Sema/SemaChecking.cpp
  clang/test/Sema/warn-free-nonheap-object.cpp
  mlir/lib/IR/OperationSupport.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102728.346280.patch
Type: text/x-patch
Size: 4399 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210518/f1efe0a7/attachment-0001.bin>


More information about the cfe-commits mailing list