[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

[Jason Liu via Phabricator via cfe-commits]

jasonliu added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4964
   if (!RawTriple.isOSDarwin() && !RawTriple.isNVPTX() &&
-      !RawTriple.isAMDGPU() && !RawTriple.isOSAIX())
+      !RawTriple.isAMDGPU())
     CmdArgs.push_back("-mconstructor-aliases");
----------------
Format as clang-format suggest. You could run clang-format or git-clang-format just for your commits by the way. 


================
Comment at: clang/test/Driver/aix-constructor-alias.c:3
-
-// RUN: %clang -### -target powerpc-ibm-aix7.1.0.0 %s -c -o %t.o 2>&1 \
-// RUN:   | FileCheck %s
----------------
Instead of removing this file, we want to check if `-mconstructor-aliases` is passed in for AIX.
Check if there are other existing files doing it for other target, then you just need to add the check for AIX target in other files.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-alias.ll:4
-
-; RUN: llc -verify-machineinstrs -mtriple powerpc-ibm-aix-xcoff -mcpu=pwr4 \
-; RUN:     -mattr=-altivec -data-sections=false -xcoff-traceback-table=false < %s | \
----------------
I don't think we want to remove the testing of our alias implementation. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102724/new/

https://reviews.llvm.org/D102724