[PATCH] D102683: [analyzer] Check the checker name, rather than the ProgramPointTag when silencing a checker

[Artem Dergachev via Phabricator via cfe-commits]

NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Oof. Accurate!

>   // Would it be more elegant to create the emitting checkers tag here? Mind that this is a checker that houses many others.

I think the checkers should have a right to attach custom tags to their nodes. This right guarantees that they can create multiple different nodes with the same state (eg., the error state) and point (eg., the error point). Not sure why would they need it but I guess in some cases it may be easier for the checker to generate an extra node than to pass existing node around, as the existing node may be next to impossible to retrieve given that `addTransition()` with the same state will simply return null if the node is already there. So, like, the same reason why generally we allow checkers to chain nodes instead of forcing them to make all changes in a single transition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102683/new/

https://reviews.llvm.org/D102683