[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

[Nathan Sidwell via Phabricator via cfe-commits]

urnathan added inline comments.


================
Comment at: clang/lib/AST/ASTImporter.cpp:4654
+
+  return ImportUsingShadowDecls(D, ToUsingEnum);
 }
----------------
martong wrote:
> Could it work if you imported the shadow declarations **before** creating the `UsingEnumDecl`? I yes, then that would be the preferred approach b/c that would fix the `// FIXME: We return error here but the definition is already created`.
Unfortunately the shadow decls refer back to the using decl, so we must do it in this order.  This is the same comment as in the existing UsingDecl importer, not a new fixme unique to using-enum.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102241/new/

https://reviews.llvm.org/D102241