[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks
Johannes Doerfert via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 17 16:36:10 PDT 2021
jdoerfert added a subscriber: ABataev.
jdoerfert added a comment.
In D101849#2764703 <https://reviews.llvm.org/D101849#2764703>, @mikerice wrote:
>> // RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -O1 -fopenmp-simd -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK10
>
> Is there a good reason to run this with -O1? Doing so makes it super sensitive to which llvm passes run and now this test fails for us now with x86 as well.
One of the O1 <https://reviews.llvm.org/owners/package/1/> was introduced by 6e8248fdad5fc59306beb286a3089fe401460826 and I cannot really tell why we would need it.
@ABataev do you remember if the O1 <https://reviews.llvm.org/owners/package/1/> was needed?
If not I'd suggest to remove the O1 <https://reviews.llvm.org/owners/package/1/> run line or add -disable-llvm-optzns to the run line.
If it is needed, we can have a simple parallel for test with manual check lines.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101849/new/
https://reviews.llvm.org/D101849
More information about the cfe-commits
mailing list