[PATCH] D102654: [DebugInfo][test] Check specific func name to ignore codegen differences

Jinsong Ji via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 17 14:23:45 PDT 2021


jsji created this revision.
jsji added reviewers: PowerPC, dblaikie, shchenz.
jsji requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

We use `CHECK-LABEL: define` to divide input stream into functions,
this works well on most platforms.

But there are cases that some platforms (eg: AIX) may have different
codegen , especially for global constructor and descructors.

On AIX, the codegen will have two more functions: __dtor_b,
__finalize_b, which will fail the test.

The fix is to use specific function name so that we can safely ignore
those unrelated codegen differences.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102654

Files:
  clang/test/CodeGenCXX/debug-info-line.cpp


Index: clang/test/CodeGenCXX/debug-info-line.cpp
===================================================================
--- clang/test/CodeGenCXX/debug-info-line.cpp
+++ clang/test/CodeGenCXX/debug-info-line.cpp
@@ -146,7 +146,7 @@
     (fn(),   //
      bar())};
 
-// CHECK-LABEL: define
+// CHECK-LABEL: f11
 __complex double f11() {
   __complex double f;
 // CHECK: store {{.*}} !dbg [[DBG_F11:!.*]]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102654.345995.patch
Type: text/x-patch
Size: 402 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210517/9cf671bc/attachment-0001.bin>


More information about the cfe-commits mailing list