[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

[Evgenii Stepanov via Phabricator via cfe-commits]

eugenis added a comment.

You are adding a new global to every translation unit.

- Private linkage would not allow them to be merged, this can have significant binary size and RAM overhead.
- There is no guarantee that any of these globals will end up to the left of any sanitized globals. With -fdata-sections, the linker is free to reorder.
- It is also not referenced from anything, so -gc-sections is likely to kill it.

It looks like this will only work in very limited circumstances.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102592/new/

https://reviews.llvm.org/D102592