[PATCH] D102556: [HIP] Fix spack detection

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: clang/test/Driver/rocm-detect.hip:115
+
+// SPACK-MISS-SILENT-NOT: SPACK package hip-4.0.0 not found at
+// SPACK-MISS-SILENT-NOT: SPACK package rocm-device-libs-4.0.0 not found at
----------------
tra wrote:
> Nit: I'd match the version with a regex. Otherwise this test would continue passing even if compiler were to report `hip-some.other.version not found` 
will do


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102556/new/

https://reviews.llvm.org/D102556