[PATCH] D102519: [clangd] Set FileSystem for tweaks in Check tool.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

thanks, lgtm!



================
Comment at: clang-tools-extra/clangd/tool/Check.cpp:215
                                  nullptr);
-      for (const auto &T :
-           prepareTweaks(Selection, Opts.TweakFilter, Opts.FeatureModules)) {
+      auto Tweaks =
+          prepareTweaks(Selection, Opts.TweakFilter, Opts.FeatureModules);
----------------
IIUC, the ordering here is to ensure `FS` is not available during `prepare` but exists in `apply`. That sounds sane, as we would like prepare to be fast, and IO is likely slow.
But this is very subtle, so deserves a comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102519/new/

https://reviews.llvm.org/D102519