[PATCH] D102482: [clang][deps] NFC: Report modules' context hash

Mon May 17 00:34:47 PDT 2021

jansvoboda11 added a comment.

Thanks for the review!

================
Comment at: clang/include/clang/Frontend/CompilerInstance.h:230-232
-  std::shared_ptr<CompilerInvocation> getInvocationPtr() {
+  CompilerInvocation &getInvocation() {
     assert(Invocation && "Compiler instance has no invocation!");
-    return Invocation;
----------------
dexonsmith wrote:
> It'd be nice to remove this API separately in a follow up patch; the change to CompilerInstance.h is not necessary here so it's easy to split, focusing the patch on the relevant changes, and that pattern is easier for reverting (especially in out-of-tree code).
> 
Committed separately as d9cb70ba29dbd74aac294caad0686f1ed52295f9.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102482/new/

https://reviews.llvm.org/D102482